From: Christophe Fergeau <cfergeau@redhat.com>
Date: Sun, 20 Dec 2015 19:51:52 +0000 (+0100)
Subject: NetworkAgent: Fix double-unref in get_secrets_keyring_cb()
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~1025
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=021cecbce289f1d9c68a156d5b8dd204a73bc715;p=gnome-shell.git

NetworkAgent: Fix double-unref in get_secrets_keyring_cb()

In get_secrets_keyring_cb, we own a ref on the 'attributes' hash table
from secret_item_get_attributes), and a ref on the 'secret' object (from
secret_item_get_secret(), but in the SHELL_KEYRING_SK_TAG case, we unref
these once before breaking out of the loop, and the second time after
breaking out of the loop.

https://bugzilla.gnome.org/show_bug.cgi?id=759708
---

diff --git a/src/shell-network-agent.c b/src/shell-network-agent.c
index 5d991673d..da0f7e551 100644
--- a/src/shell-network-agent.c
+++ b/src/shell-network-agent.c
@@ -314,8 +314,6 @@ get_secrets_keyring_cb (GObject            *source,
 
               secrets_found = TRUE;
 
-              g_hash_table_unref (attributes);
-              secret_value_unref (secret);
               break;
             }
         }